search

swift-server / swift-aws-lambda-runtime

Swift implementation of AWS Lambda Runtime
Apache License 2.0
1.12k stars 101 forks source link

Add guards for code that relies on _Concurrency to allow compilation with Xcode 13 #236

Closed programmarchy closed 2 years ago

programmarchy commented 2 years ago

Add extra code guards so that Xcode 13 will compile this package on macOS 11, which does not have symbols for Concurrency yet.

Motivation:

Allow compilation with Xcode 13

Modifications:

Changed code guards #if compiler(>=5.5) to #if compiler(>=5.5) && canImport(_Concurrency)

Got the idea from swift-server/swift-service-lifecycle#110

Result:

Successfully compiles with Xcode 13

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

programmarchy commented 2 years ago

In case it's of interest, I also have another branch that applies a similar patch to main: https://github.com/programmarchy/swift-aws-lambda-runtime/tree/fix-xcode13

programmarchy commented 2 years ago

Related: https://github.com/swift-server/swift-aws-lambda-runtime/issues/234

tomerd commented 2 years ago

@swift-server-bot test this please

tomerd commented 2 years ago

@programmarchy could you reopen this against the v0 branch? we will track 0.x releases from that branch

programmarchy commented 2 years ago

@tomerd https://github.com/swift-server/swift-aws-lambda-runtime/pull/237