search

swift-server / swift-aws-lambda-runtime

Swift implementation of AWS Lambda Runtime
Apache License 2.0
1.12k stars 101 forks source link

Add default value for traceID header #246

Closed StefanNienhuis closed 2 years ago

StefanNienhuis commented 2 years ago

Adds a default value for the Lambda-Runtime-Trace-Id header, to make it compatible with the AWS SAM CLI and other applications depending on the Lambda Runtime Interface Emulator.

Motivation:

Currently the Swift Runtime is incompatible with the Lambda Runtime Interface Emulator.

Modifications:

Adds a default value for the Lambda-Runtime-Trace-Id header.

This is similar to what the Rust runtime is doing.

Result:

The Swift Runtime will be compatible with the Lambda Runtime Interface Emulator.

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

swift-server-bot commented 2 years ago

Can one of the admins verify this patch?

tomerd commented 2 years ago

@swift-server-bot test this please

tomerd commented 2 years ago

thanks @StefanNienhuis see feedback inline

StefanNienhuis commented 2 years ago

@tomerd Sorry for the delay. Should be ready now.

fabianfett commented 2 years ago

@swift-server-bot test this please

tomerd commented 2 years ago

thanks @StefanNienhuis looks like there are some formatting issues the validation script found. you can also run it locally with docker-compose -f docker/docker-compose.yaml run --rm soundness

fabianfett commented 2 years ago

@swift-server-bot test this please