search

swift-server / swift-aws-lambda-runtime

Swift implementation of AWS Lambda Runtime
Apache License 2.0
1.14k stars 102 forks source link

CI builds fails with Swift 5.9 and Swift nightly #304

Closed sebsto closed 1 year ago

sebsto commented 1 year ago

Expected behavior

CI build should succeed without errors

Actual behavior

CI builds fails with

docker-compose -f docker/docker-compose.yaml -f docker/docker-compose.al2.59.yaml -p swift-aws-lambda-runtime-swift59-prb run --rm test

fails with a fatal error. 

/code/.build/checkouts/swift-docc-plugin/Plugins/Swift-DocC Convert/Symbolic Links/SharedPackagePluginExtensions/PackageExtensions.swift:31:17: warning: switch covers known cases, but 'TargetDependency' may have additional unknown values
                switch dependency {
                ^
/code/.build/checkouts/swift-docc-plugin/Plugins/Swift-DocC Convert/Symbolic Links/SharedPackagePluginExtensions/PackageExtensions.swift:31:17: note: handle unknown values using "@unknown default"
                switch dependency {
                ^
/code/.build/checkouts/swift-docc-plugin/Plugins/Swift-DocC Preview/Symbolic Links/SharedPackagePluginExtensions/PackageExtensions.swift:31:17: warning: switch covers known cases, but 'TargetDependency' may have additional unknown values
                switch dependency {
                ^
/code/.build/checkouts/swift-docc-plugin/Plugins/Swift-DocC Preview/Symbolic Links/SharedPackagePluginExtensions/PackageExtensions.swift:31:17: note: handle unknown values using "@unknown default"
                switch dependency {

...

15:48:54 /code/Sources/AWSLambdaRuntimeCore/LambdaContext.swift:15:17: remark: '@preconcurrency' attribute on module 'Dispatch' is unused
15:48:54 @preconcurrency import Dispatch
15:48:54 ~~~~~~~~~~~~~~~~^
15:48:54 [282/295] Compiling AWSLambdaRuntimeCore LambdaContext.swift
15:48:54 /code/Sources/AWSLambdaRuntimeCore/LambdaContext.swift:15:17: remark: '@preconcurrency' attribute on module 'Dispatch' is unused
15:48:54 @preconcurrency import Dispatch
15:48:54 ~~~~~~~~~~~~~~~~^
15:48:54 [283/295] Compiling AWSLambdaRuntimeCore Lambda+String.swift
15:48:54 /code/Sources/AWSLambdaRuntimeCore/Lambda.swift:88:23: error: 'install()' is deprecated: This is no longer needed in Swift 5.9
15:48:54             Backtrace.install()
15:48:54                       ^
15:48:54 [284/295] Compiling AWSLambdaRuntimeCore Lambda.swift
15:48:54 /code/Sources/AWSLambdaRuntimeCore/Lambda.swift:88:23: error: 'install()' is deprecated: This is no longer needed in Swift 5.9
15:48:54             Backtrace.install()
15:48:54                       ^
15:48:54 error: fatalError
15:48:54 error: fatalError

Steps to reproduce

Submit a PR and issue @swift-server-bot test this please

If possible, minimal yet complete reproducer code (or URL to code)

See https://github.com/swift-server/swift-aws-lambda-runtime/pull/300

What version of this project (swift-aws-lambda-runtime) are you using?

1.0.0-alpha1

Swift version

bash-4.2# swift --version && uname -a 
Swift version 5.9-dev (LLVM 9cdc27a2fb48dda, Swift f42cd3b53880c62)
Target: aarch64-unknown-linux-gnu
Linux e7a81f99736b 5.15.49-linuxkit-pr #1 SMP PREEMPT Thu May 25 07:27:39 UTC 2023 aarch64 aarch64 aarch64 GNU/Linux

Amazon Linux 2 docker image version

al2-5.9

sebsto commented 1 year ago

root cause : https://github.com/swift-server/swift-backtrace/pull/68

tomerd commented 1 year ago

https://github.com/swift-server/swift-aws-lambda-runtime/pull/305

sebsto commented 1 year ago

Thanks !

sebsto commented 1 year ago

I confirm this is fixed now - thank you