search

swift-server / swift-backtrace

💥 Backtraces for Swift on Linux and Windows
Apache License 2.0
296 stars 34 forks source link

Disable this library for Swift 5.9 and above. #68

Closed al45tair closed 1 year ago

al45tair commented 1 year ago

Swift 5.9 has a new built-in backtrace-on-crash facility, which supersedes this library.

rdar://111109405

al45tair commented 1 year ago

@swift-server-bot test this please

al45tair commented 1 year ago

For now, I've left this enabled on Windows, as Windows support isn't landed in the Swift runtime yet.

tomerd commented 1 year ago

@swift-server-bot add to allowlist

tomerd commented 1 year ago

@al45tair the CI test run with warnings as errors, so you may want to also conditionalize any test and sample code. note the CI jobs can be reproduced locally by invoking the same docker compose commands the CI job does

al45tair commented 1 year ago

@swift-server-bot test this please

al45tair commented 1 year ago

@swift-server-bot test this please

al45tair commented 1 year ago

We'll want to hold off on merging this until https://github.com/apple/swift/pull/67483 and its 5.9 counterpart have gone through and the results have landed in a nightly.