search

swift-server / swift-prometheus

Prometheus client library for Swift
https://swiftpackageindex.com/swift-server/swift-prometheus
Apache License 2.0
142 stars 30 forks source link

Change 'unsafeDowncast' to 'as!' #115

Closed glbrntt closed 2 months ago

glbrntt commented 2 months ago

Motivation:

The 'unsafeDowncast' can cause a miscompile leading to unexpected runtime behaviour.

Modifications:

Result:

No miscompiles on 5.10

fabianfett commented 2 months ago

@swift-server-bot test this please

ktoso commented 2 months ago

@swift-server-bot test this please

ktoso commented 2 months ago

@swift-server-bot add to allowlist