search

swift-server / swift-prometheus

Prometheus client library for Swift
https://swiftpackageindex.com/swift-server/swift-prometheus
Apache License 2.0
145 stars 32 forks source link

Trying to tag from 0.0.0-alpha.1 gets you 0.3.0 #14

Closed Yasumoto closed 5 years ago

Yasumoto commented 5 years ago

Steps to reproduce

Specify this in your Package.swift

.package(url: "https://github.com/MrLotU/SwiftPrometheus.git", from: "0.0.0-alpha.1")

and you'll pull in version 0.3.0.

I know mucking with published git tags isn't ideal, but maybe we should delete the old 0.3.0 releases and rename them to something that won't collide with the NIO1-supported tags? 🤔

Expected behavior

We get "mainline" 0.0.0 versions.

MrLotU commented 5 years ago

Ah, dang. I thought the SPM versioning system would cover us there. Another option would be to publish a 1.x for NIO 1 and go directly to 2.x for NIO 2. Happy to hear anyone's thoughts.

Yasumoto commented 5 years ago

Ooh, smart. I like the 1.x for NIO 1.x and 2.x for NIO 2.x, especially since it matches that versioning. Other benefit is we keep the early-days history intact.

weissi commented 5 years ago

@MrLotU / @Yasumoto but from: 0.0.0-alpha.1 means 0.0.0-alpha.1 ..< 1.0.0 so that you would get a 0.3.0 (if released) is correct, right?

MrLotU commented 5 years ago

Yeah, this is the problem right now. I already had a 0.3.0 released previously. But right now users should get 0.0.0-alpha.1 not 0.3.0 since it's newer.

weissi commented 5 years ago

@MrLotU why not 1.0.0-alpha.1 then?

weissi commented 5 years ago

or 0.4.0-alpha.1

MrLotU commented 5 years ago

We have that too, for the NIO 2 supported version :)

weissi commented 5 years ago

:)

MrLotU commented 5 years ago

0.4.0-alpha.1 would work. But I think 0.3.0 -> 0.4.0-alpha.1 will have some breaking changes

weissi commented 5 years ago

But I think 0.3.0 -> 0.4.0-alpha.1 will have some breaking changes

As per SemVer that's okay for 0.x stuff, also already you have 0.0.0-alpha.1 --> 0.3.0 with breaking changes, right?

MrLotU commented 5 years ago

Ah, yeah. I think that's the easiest way to resolve this for now then. I'll publish 0.4.0-alpha.1 :)

Yasumoto commented 5 years ago

Best of all worlds, thanks friends!

MrLotU commented 5 years ago

0.4.0-alpha.1 released. @Yasumoto could you please check if updating to from: "0.4.0-alpha.1 works and if so, close this issue? 😄

Yasumoto commented 5 years ago

Yep! Updated https://github.com/vapor-community/VaporMonitoring/pull/5 and working a-ok 👌 🎉