swiftbar / SwiftBar

Powerful macOS menu bar customization tool
https://swiftbar.app
MIT License
2.93k stars 92 forks source link

Semantic versioning #234

Closed fenhl closed 2 years ago

fenhl commented 3 years ago

I have a plugin that checks for SwiftBar updates by comparing the CFBundleShortVersionString from /Applications/SwiftBar.app/Contents/Info.plist with the latest version from the Homebrew API. This check started to error with 1.4 because its CFBundleShortVersionString is 1.4, not 1.4.0. Would it be possible to add a check to your release workflow to make sure the version is a valid semver?

melonamin commented 3 years ago

Damn it, what a stupid mistake on my end... My current release workflow is "I just go and do it" -_-

I think I can add a check into Xcode build process, let me do some research