Move away from resource helper.

swiftcsv / SwiftCSV

CSV parser for Swift

MIT License

956 stars 192 forks source link

Move away from resource helper. #131

Closed Diggory closed 1 year ago

Diggory commented 1 year ago

Updates swift tools version in manifest to 5.5 Moves test sample files into their own directory. Removes ResourceHelper and uses built-in function for getting resources as offered by SPM since 5.5 Fixes #130

DivineDominion commented 1 year ago

The CSV file copy phase looks nice!

Could you double check that the Xcode Project in the SwiftCSV still compiles and tests? I believe you need to switch between Bundle.module for SPM and Bundle.init for Carthage, direct build, etc., see: https://github.com/swiftcsv/SwiftCSV/issues/130#issuecomment-1699683262

Diggory commented 1 year ago

Ah! I didn't check the Xcode project. I now have a separate branch which solves that (and brings back ResourceHelper.)

I will close this PR and generate another one from that branch.
Thanks!