search

swiftcsv / SwiftCSV

CSV parser for Swift
MIT License
962 stars 193 forks source link

No account for carriage character in Parser.swift within isNewLine() #36

Closed laus102 closed 5 years ago

laus102 commented 8 years ago

screen shot 2016-05-13 at 3 56 15 pm

This was giving me some trouble with file input. The attached image is the corrected method implementation.

chamander commented 8 years ago

Thanks for picking that up, @laus102 !

Some of the semantics behind checking for a newline has been changed in my branch. Along with that, I've interpreted your solution into it as well.

I intend to open a request for that branch into the base fork when Swift 3 migration branches have gone through review.

Please see the following pull request for the changes and let me know what you think, in the request. https://github.com/gavanchan/SwiftCSV/pull/3

For the specific commits involving the issue you found, _please see:_ 482804d - Introduction of the change w/ your logic. 85d2592 - Source update with the new change.

DivineDominion commented 5 years ago

Fixed already 👍