Swift Package Manager - Githubissues

swiftcsv / SwiftCSV

CSV parser for Swift

MIT License

962 stars 193 forks source link

Swift Package Manager #58

Closed kgn closed 5 years ago

kgn commented 7 years ago

I added support for Swift Package Manager, the changes needed to get this working were:

Move source files into Sources directory
Move test files into Tests/SwiftCSVTests
Change how the test csv files are loaded so they can be loaded when running tests via swift test

I also added support for running the tests on Linux to make sure the library works on that platform. There is a simple Dockerfile to run the tests by running docker build . in the root of the project.

swiftylondon commented 7 years ago

@kgn looks like Travis CI breaking again Code 65 error appears to be a known issue:

https://github.com/travis-ci/travis-ci/issues/6675

Any ideas on how to fix?

swiftylondon commented 7 years ago

Looks good - nice one.

swiftylondon commented 7 years ago

@naoty I don't seem to have permission levels to merge. Can you do it? Merge to develop and lets push this out! Nice work @kgn - thanks!

swiftylondon commented 7 years ago

unless @kgn can you fix the conflicts by pulling latest develop?

kgn commented 7 years ago

hmm, I'm not sure what's conflicting. I tried to rebase the changes from naoty/develop onto my branch but still saying there are conflicts

kgn commented 7 years ago

@swiftylondon all my changes were after your last commit to develop so not sure what GitHub is complaining about

grantkemp commented 7 years ago

@kgn it looks like there are some conflicts...^^ can you resolve them?

DivineDominion commented 5 years ago

@kgn I'm by no means a SwiftPM expert, so could you have a look at the state of everything now that the repository is cleaned up a bit?

DivineDominion commented 5 years ago

Closed via #77 as a working example