orangeince commented 5 years ago

I find this repo when I try to make a small tool to parse csv files. It's awesome! But the only regret is that it does not support SPM. So I made this PR to do something for others.

It is easy to use new version of swift tool. But there is one not good of SPM, it does not support include resources with targets, it's a bug. So, in order to pass the test case, I added a ResourceHelper to get the url of resource.

codecov-io commented 5 years ago

Codecov Report

Merging #77 into master will decrease coverage by 0.56%. The diff coverage is 72.72%.

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
- Coverage   92.53%   91.96%   -0.57%     
==========================================
  Files          13       14       +1     
  Lines         415      423       +8     
==========================================
+ Hits          384      389       +5     
- Misses         31       34       +3

Impacted Files	Coverage Δ
SwiftCSVTests/URLTests.swift	`100% <100%> (ø)`	:arrow_up:
SwiftCSVTests/PerformanceTest.swift	`100% <100%> (ø)`	:arrow_up:
SwiftCSVTests/ResourceHelper.swift	`62.5% <62.5%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a5ac63...9bcefaa. Read the comment docs.

DivineDominion commented 5 years ago

Thanks for contributing! I've invited you to join the SwiftCSV GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines.

orangeince commented 5 years ago

@DivineDominion Cool! I'd like to do something to make it prefect!

swiftcsv / SwiftCSV

Support Swift Package Manager. #77

Codecov Report