search

swiftcsv / SwiftCSV

CSV parser for Swift
MIT License
951 stars 191 forks source link

It may be of interest that SwiftCSV runs on a linux plattform too #82

Closed mschrettenbrunner closed 2 years ago

mschrettenbrunner commented 4 years ago

I made minor changes in ParsingState.swift:

all relevant lines from: if char == "\"" {

to: if char == "\u{005c}" {

DivineDominion commented 4 years ago

Cool! Would you like to create a PR for this? Linux support sounds great. Maybe I can figure out how to add this to CI 🤔

mschrettenbrunner commented 4 years ago

... I appreciate your code :-) and use it in a linux environment with Swift4TF (CUDA)

DivineDominion commented 4 years ago

Cool! :) Would you be interested in a PR? Universal platform support would be grat!

If not, I'd close this issue for now, with two very sad eyes :)

mschrettenbrunner commented 4 years ago

@DivineDominion Thanks for following up. No need to have sad eyes : -) Code runs flawless. I will do it as soon as I've finished some tasks Regards Manfred

DivineDominion commented 4 years ago

@mschrettenbrunner did you make progress on this? Don't want to bug, am just considering how to plan the next point release.

mschrettenbrunner commented 4 years ago

@DivineDominion, thanks for following up :-) If you want to accelerate, you may provide a pure data file as a test case for validation of compatibility in my enviroment.

DivineDominion commented 2 years ago

@mschrettenbrunner I mostly rely on the unit tests. Some more fixtures would be great, but since they're not there, the unit tests are the best benchmark for cross-platform compatibility. I'll close this issue for now and we await your PR!