search

swiftcsv / SwiftCSV

CSV parser for Swift
MIT License
947 stars 190 forks source link

Change View protol to CSVView for SwiftUI compatibility #93

Closed campionfellin closed 3 years ago

campionfellin commented 3 years ago

Closes https://github.com/swiftcsv/SwiftCSV/issues/89

Signed-off-by: campionfellin campionfellin@gmail.com

codecov-io commented 3 years ago

Codecov Report

Merging #93 (581dfb7) into master (8061807) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #93   +/-   ##
=======================================
  Coverage   92.53%   92.53%           
=======================================
  Files          14       14           
  Lines         402      402           
=======================================
  Hits          372      372           
  Misses         30       30
Impacted Files Coverage Δ
SwiftCSV/CSV.swift 71.42% <ø> (ø)
SwiftCSV/EnumeratedView.swift 100.00% <ø> (ø)
SwiftCSV/NamedView.swift 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8061807...581dfb7. Read the comment docs.

DivineDominion commented 3 years ago

Thanks for the fix, @campionfellin !

We've invited you to join the SwiftCSV GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines.

campionfellin commented 3 years ago

Sounds great! Thanks for the quick review @DivineDominion . This is the first Pod that I've contributed to, does the version need to be bumped to be able to use it now?