Achieve Carthage compatibility by compiling source file in target's build phase

swiftgif / SwiftGif

[UNMAINTAINED] 🌠 A small UIImage extension with gif support

MIT License

1.33k stars 306 forks source link

Achieve Carthage compatibility by compiling source file in target's build phase #57

Closed tforzaglia closed 6 years ago

tforzaglia commented 7 years ago

Hey, @bahlo

Great framework here! Very useful for an app I'm working on. I'm using Carthage in my app and was unfortunately having a problem with integrating SwiftGif. Based on #48, it seems that others have also had similar problems with using Carthage to integrate SwiftGif.

Anyway, this PR should fix the issue. Feel free to test it out and merge if you like.

tomorrowkey commented 6 years ago

Is there any problem to merge?

tforzaglia commented 6 years ago

@tomorrowkey, this is all good to merge from my point of view, but as this repository belongs to @bahlo, he will need to evaluate and merge if he is satisfied with my pull request.

bahlo commented 6 years ago

Thank you very much!

tanukiti1987 commented 6 years ago

@bahlo Thank you 👍 Is there the plan to release new version at CocoaPods and Carthage?

jgs0 commented 5 years ago

I had the same problem last week. Everything up to date, I guess:

Cartfile: github "bahlo/SwiftGif" >= 1.6.1

Terminal: xcodebuild -version Xcode 10.1 Build version 10B61

The Framework is build but it seams to be empty... as a fix I just use the modulefile source directly.