search

swiftkube / client

Swift client for Kubernetes
Apache License 2.0
129 stars 20 forks source link

fix: typo in property name for storage V1 api group #11

Closed portellaa closed 3 years ago

portellaa commented 3 years ago

Hello 👋

First of all great work. It's my first time using the lib and i found it with a very amusing interface 😍

I just found out a typo in the the property to access the storage and i thought i could contribute with this dummy fix and thank you for this.

So feel free to deny this simple PR, the main idea was to thank you for your work 🙇

Please let me know if i can help you with something 🙏 I use to be an iOS developer for several years, always enjoying backend and since things like PerfectSwift, Vapor and Kitura(no longer with us) appeared i decide to move back to backend and trying to push the usage of Swift on it, so i'm glad to help in what i can 😊

Cheers

iabudiab commented 3 years ago

@portellaa Hey there 👋

Really glad that you like the project and I appreciate it, that you took the time to open this PR 👍

I too was an iOS dev then moved to the server side of things 😬

If you want to help then use the lib, make interesting things with it and keep opening PRs, Issues, no matter how small 😉

Hope to see around 😸

Cheers 🍻

portellaa commented 3 years ago

hi @iabudiab nice to meet you

i may have a new one coming out with a proposition of a kind of CRD support, well at least basic manipulation of custom resources.

let's see if you guys like it 🙇

cheers 🍻

iabudiab commented 3 years ago

Hey @portellaa nice to meet you too 😺

Keep them coming 👍 CRD support is on the top of the todo list, however, I couldn't find the time to finish it yet. I've got some early ideas/drafts but nothing concrete. So if you want to give it a go, then godspeed 🚀

Cheers