search

swiftkube / client

Swift client for Kubernetes
Apache License 2.0
129 stars 20 forks source link

fixes bug when trying to fetch logs without following #16

Closed thomashorrobin closed 2 years ago

thomashorrobin commented 2 years ago

After some investigation it turns out that sending follow=true in the query of any request to the Kubernetes API changes the behaviour of the response significantly. So it's critical that it is not sent if the request is not intended to stream the result. I've modified the code so we can easily distinguish between a "dump" of the logs and a stream of the logs

iabudiab commented 2 years ago

@thomashorrobin 👍 nice catch. I'll test and merge soon.