search

swiftkube / client

Swift client for Kubernetes
Apache License 2.0
129 stars 20 forks source link

Add optional `previous` & `timestamps` flags to log requests #35

Closed ewilken closed 1 year ago

ewilken commented 1 year ago

This PR introduces the optional boolean arguments previous and timestamps to the logs() method and the optional boolean argument timestamps to the follow() method, to be able to request a pod's previously terminated container from the API and to be able to toggle timestamps on the log responses and streams on and off.

I've initialized all arguments as false to be able to just ignore them without breaking backwards compatibility. Please let me know if this makes sense to you the way it's implemented or if you'd prefer it differently.

And again, thanks for all the effort you're putting into this project! 🙂

iabudiab commented 1 year ago

@ewilken Nice! Thanks for the PR 👍