[CMake] Fold export_executable_symbols_* into function args

swiftlang / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. This fork is used to manage Swift’s stable releases of Clang as well as support the Swift project.

https://llvm.org

Other

1.12k stars 331 forks source link

[CMake] Fold export_executable_symbols_* into function args #9130

Closed cachemeifyoucan closed 2 months ago

cachemeifyoucan commented 2 months ago

Fix the builds with LLVM_TOOL_LLVM_DRIVER_BUILD enabled.

LLVM_ENABLE_EXPORTED_SYMBOLS_IN_EXECUTABLES is not completely compatible with export_executable_symbols as the later will be ignored if the previous is set to NO.

Fix the issue by passing if symbols need to be exported to llvm_add_exectuable so the link flag can be determined directly without calling export_executablesymbols* later.

cachemeifyoucan commented 2 months ago

@swift-ci please test llvm