search

swiftlang / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. This fork is used to manage Swift’s stable releases of Clang as well as support the Swift project.
https://llvm.org
Other
1.12k stars 331 forks source link

[lldb] Fix SwiftASTContext creatiion when swift caching is used #9137

Closed cachemeifyoucan closed 2 months ago

cachemeifyoucan commented 2 months ago

Followup to #9088, handle the cc1 flag deserialization when swift caching is enabled. LLDB should ignore all the CAS related options from embedded flags since LLDB doesn't receive the correct CAS configuration and should just load the modules from disk directly.

rdar://134090397

cachemeifyoucan commented 2 months ago

@swift-ci please test

cachemeifyoucan commented 2 months ago

@swift-ci please test

cachemeifyoucan commented 2 months ago

@swift-ci please test

cachemeifyoucan commented 2 months ago

Please test with following pull request: https://github.com/swiftlang/swift/pull/75964

@swift-ci please test

cachemeifyoucan commented 2 months ago

@swift-ci please test

cachemeifyoucan commented 2 months ago

@swift-ci please test macOS platform

adrian-prantl commented 2 months ago

@cachemeifyoucan This is on the wrong branch. Can you rebase this on swift/release/6.0 and then afterwards cherry-pick it to stable/202407.. and next?

cachemeifyoucan commented 2 months ago

@cachemeifyoucan This is on the wrong branch. Can you rebase this on swift/release/6.0 and then afterwards cherry-pick it to stable/202407.. and next?

I thought you land on stable/2023... first before gets integrate to release/6.0. Sure I can re-target 6.0 and that should auto forward to stable/2023.

cachemeifyoucan commented 2 months ago

@swift-ci please test

cachemeifyoucan commented 2 months ago

@swift-ci please test windows platform

cachemeifyoucan commented 2 months ago

@adrian-prantl Can you approve and merge for release/6.0?

adrian-prantl commented 2 months ago

I thought you land on stable/2023... first before gets integrate to release/6.0. Sure I can re-target 6.0 and that should auto forward to stable/2023.

The LLDB automerger flows in the opposite direction.