search

swiftlang / llvm-project

The LLVM Project is a collection of modular and reusable compiler and toolchain technologies. This fork is used to manage Swift’s stable releases of Clang as well as support the Swift project.
https://llvm.org
Other
1.11k stars 328 forks source link

[cherry-pick swift/release/6.0][clang][modules] Built-in modules are not correctly enabled for Mac Catalyst #9152

Closed ian-twilightcoder closed 3 weeks ago

ian-twilightcoder commented 3 weeks ago

Mac Catalyst is the iOS platform, but it builds against the macOS SDK and so it needs to be checking the macOS SDK version instead of the iOS one. Add tests against a greater-than SDK version just to make sure this works beyond the initially supporting SDKs.

rdar://116490661

ian-twilightcoder commented 3 weeks ago

Explanation: This change is required for open source clang to be able to work with Mac Catalyst wit the SDKs in Xcode 16 beta 5 and beyond. (It will break compatibility for the earlier betas, but not the earlier releases.) Radar (and possibly SR Issue): rdar://116490661 Scope: This affects compiling for Mac Catalyst against the Xcode 16 beta SDKs, it does not affect previous (Xcode 15 and earlier) SDKs. Risk: None anticipated. Testing: Local testing, CI. Reviewed By: Cyndy Ishida (cyndyishida)

ian-twilightcoder commented 3 weeks ago

@swift-ci test llvm

ian-twilightcoder commented 3 weeks ago

@swift-ci test

ian-twilightcoder commented 3 weeks ago

LLVM errors are just the expected -emit-llvm-only ones.