swiftlang / sourcekit-lsp

Language Server Protocol implementation for Swift and C-based languages
Apache License 2.0
3.21k stars 264 forks source link

Populate inProgressRequest with the same priority that we cancel requests #1419

Closed ahoppen closed 1 month ago

ahoppen commented 1 month ago

Others, this could lead to interesting priority inversions: We would handle the cancellation with higher priority than the population of inProgressRequest, which means that we wouldn’t actually cancel the request, loggingCannot cancel request because it hasn't been scheduled for execution yet or because the request already returned a response`.

ahoppen commented 1 month ago

@swift-ci Please test