Fix a race condition in `LocalConnection`

swiftlang / sourcekit-lsp

Language Server Protocol implementation for Swift and C-based languages

Apache License 2.0

3.3k stars 273 forks source link

Fix a race condition in `LocalConnection` #1431

Closed ahoppen closed 4 months ago

ahoppen commented 4 months ago

The comment on LocalConnection assumed that all mutable state was guarded by queue but state and handler actually weren’t. This was found by the thread sanitizer.

ahoppen commented 4 months ago

@swift-ci Please test