Only report log collection progress in `sourcekit-lsp diagnose` if we’ve made meaningful progress

swiftlang / sourcekit-lsp

Language Server Protocol implementation for Swift and C-based languages

Apache License 2.0

3.3k stars 273 forks source link

Only report log collection progress in `sourcekit-lsp diagnose` if we’ve made meaningful progress #1432

Closed ahoppen closed 4 months ago

ahoppen commented 4 months ago

Especially when we didn’t have a redrawing progress indicator, we would spam the output with out making progress that was visible to the user because the overall progress just shows a percentage without any decimal digits. To fix this, only report progress when we’ve made at least 1% of progress in log collection.

ahoppen commented 4 months ago

@swift-ci Please test

ahoppen commented 4 months ago

@swift-ci Please test

ahoppen commented 4 months ago

@swift-ci Please test Windows