A couple of improvements for generated interfaces

ahoppen commented 4 weeks ago

Rename methods to highlight that we’re talking about generated interfaces here, not .swiftinterface files
Don’t open the generated interface in documentManager. Opening documents in documentManager should only be done by the textDocument/didOpen notification from the LSP client. Otherwise we might indefinitely keep the document in the document manager
After getting the generated interface from sourcekitd, close the document in sourcekitd again. We don’t provide semantic functionality in the generated interface yet, so we can’t interact with the generated interface path. Before, we left it open in sourcekitd indefinitely.
A couple of code simplifications.

Fixes #878 rdar://116705653

ahoppen commented 4 weeks ago

@swift-ci Please test

ahoppen commented 3 weeks ago

IIRC sourcekitd does provide cursor-info for generated interface, is this just that we don't expose that from the LSP side yet?

Yes, we currently don’t provide any intelligent editor functionality in swift interfaces (https://github.com/apple/sourcekit-lsp/issues/1155).

swiftlang / sourcekit-lsp