Allow prefixing of the token for a `WorkDoneProgress` with a custom string

swiftlang / sourcekit-lsp

Language Server Protocol implementation for Swift and C-based languages

Apache License 2.0

3.2k stars 264 forks source link

Allow prefixing of the token for a `WorkDoneProgress` with a custom string #1493

Closed ahoppen closed 1 week ago

ahoppen commented 2 weeks ago

This allows VS Code to detect when sourcekitd has crashed and prompt the user to gather a diagnostic report + file an issue about the crash.

I took this opportunity to refactor the WorkDoneProgress that effectively counts how many tasks of this kind are going on, into a separate type. I’m not quite happy with the name SharedWorkDoneProgressManager. Happy for better suggestions if anyone has some.

rdar://129678779 Fixes #1476

ahoppen commented 2 weeks ago

@swift-ci Please test