ahoppen
commented
1 week ago - Explanation: clangd uses a completely different semantic token legend than SourceKit-LSP (it doesn’t even adhere to the ordering of the pre-defined token types) but we were passing index offsets from clangd through assuming that clangd uses the same legend, which was incorrect. When retrieving semantic tokens from clangd, translate the semantic tokens from clangd’s legend to SourceKit-LSP’s legend.
- Scope: Semantic tokens from clangd
- Risk: Low, semantic tokens for clangd are very broken without this change
- Testing: Added test case
- Issue: rdar://129895062
- Reviewer: @hamishknight and @bnbarham on https://github.com/swiftlang/sourcekit-lsp/pull/1509 and https://github.com/swiftlang/sourcekit-lsp/pull/1510