[6.0] Handle diagnostics in secondary files correctly

swiftlang / sourcekit-lsp

Language Server Protocol implementation for Swift and C-based languages

Apache License 2.0

3.29k stars 273 forks source link

Closed ahoppen closed 3 months ago

ahoppen commented 3 months ago

Explanation: sourcekitd sometimes returned notes in secondary source files but SourceKit-LSP assumed that all diagnostics and notes are in the primary source file, which was incorrect
Scope: Diagnostics
Risk: Should be fairly low, I don’t know how this would break something
Testing: Added test case
Issue: rdar://130503535, #1516
Reviewer: @hamishknight on https://github.com/swiftlang/sourcekit-lsp/pull/1528

ahoppen commented 3 months ago

@swift-ci Please test