search

swiftlang / sourcekit-lsp

Language Server Protocol implementation for Swift and C-based languages
Apache License 2.0
3.21k stars 264 forks source link

[6.0] Import new Bionic module and Android overlay #1555

Open finagolfin opened 1 week ago

finagolfin commented 1 week ago

Explanation: Now that this new overlay was merged into the 6.0 compiler too in swiftlang/swift#74758, this adds the overlay to the seven files that currently import Glibc.

Scope: Add imports on Android only

Issue: None

Original PR: #1550 and #1559

Risk: None

Testing: Passed all CI on trunk, plus on my daily Android CI, finagolfin/swift-android-sdk#151

Reviewer: @ahoppen

@bnbarham, easy review.

ahoppen commented 1 week ago

@swift-ci Please test

finagolfin commented 6 days ago

Hold off on merging, will let you know next week.

finagolfin commented 2 days ago

Alright, pulled in #1559 also, one more CI run and this can go in.

bnbarham commented 2 days ago

@swift-ci please test

finagolfin commented 19 hours ago

Passed CI, ready for merge.

bnbarham commented 8 hours ago

Seems like Windows didn't run :(

bnbarham commented 8 hours ago

@swift-ci please test Windows platform

finagolfin commented 7 hours ago

Seems like Windows didn't run :(

It did, I think the problem is that github doesn't always pick up the results of Windows CI runs.

bnbarham commented 7 hours ago

It did, I think the problem is that github doesn't always pick up the results of Windows CI runs.

Yeah, unfortunately merging is blocked for me without the status being picked up.