search

swiftlang / sourcekit-lsp

Language Server Protocol implementation for Swift and C-based languages
Apache License 2.0
3.3k stars 274 forks source link

`shutdown` result is non-null #1733

Open mattmassicotte opened 2 weeks ago

mattmassicotte commented 2 weeks ago

Swift version

swift-6.0-DEVELOPMENT-SNAPSHOT-2024-09-17-a

Platform

macOS 14.5

Editor

https://github.com/ChimeHQ/LanguageClient

Description

In response to a shutdown request, the server responds with:

{"jsonrpc":"2.0","id":2,"result":{}}

That result of {} doesn't match the specification, which indices that the result should be null.

https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#shutdown

This really isn't that big a deal, but we found it, and figured it was worth reporting.

Steps to Reproduce

send a shutdown request

Logging

No response

ahoppen commented 1 day ago

Synced to Apple’s issue tracker as rdar://137886488