search

swiftlang / sourcekit-lsp

Language Server Protocol implementation for Swift and C-based languages
Apache License 2.0
3.34k stars 280 forks source link

Fix nondeterministic test failure for tests that await next diagnostic notification #1782

Closed ahoppen closed 1 month ago

ahoppen commented 1 month ago

These tests were designed to poll for the next diagnostic notification and if that notification didn’t contain the expected result, try again.

But if we didn’t get any diagnostic notification in 1s, we would unconditionally fail instead of trying again, which was not intended.

ahoppen commented 1 month ago

@swift-ci Please test

ahoppen commented 1 month ago

@swift-ci Please test Windows

ahoppen commented 1 month ago

@swift-ci Please test Windows