swiftlang / sourcekit-lsp

Language Server Protocol implementation for Swift and C-based languages
Apache License 2.0
3.34k stars 280 forks source link

Add another import of new Android overlay and remove non-existent file exclusion from package manifest #1848

Open finagolfin opened 2 days ago

finagolfin commented 2 days ago

I don't know what's going on with the symbol lookup in the compiler, as I built the Oct. 8 trunk source snapshot fine without this import and then started seeing this file erroring this month on my Android CI, finagolfin/swift-android-sdk@15b148d1c, and now natively on Android with the Nov. 20 trunk snapshot, without any seemingly relevant changes in this file.

As for the manifest, looks like Alex copy-pasted that line from the non-test target, but tests don't have a CMake config, causing this warning on the CI which I also saw locally:

warning: 'sourcekit-lsp': Invalid Exclude '/Users/ec2-user/jenkins/workspace/swift-PR-macos-smoke-test/branch-main/sourcekit-lsp/Tests/TSCExtensionsTests/CMakeLists.txt': File not found.