Update log message to public level

[Kyle-Ye]

The current log will be <private> to end user unless the user is debugging on it.

And it makes the log message of SourceKit a bit of useless.

Inspired by digging the original issue https://github.com/apple/swift/issues/62274#issuecomment-1337940045

I think we could improve the logger method to add public modifier

os_log("%{public}@", log: xx, type: .info, xx) // If we use old API
Logger().info("\(xx, privacy: .public)") // If we can drop macOS 10.15- Support to use new API

[ahoppen]

rdar://102990224

[ahoppen]

I agree that the current situation is not ideal.

But I think the tricky bit is that the log message might contain potentially privacy-sensitive information that we don’t want to log, so marking the entire opaque string is not an option IMO. So each log call would need to decide which information it wants to mark as public and private.

[ahoppen]

I redesigned the logging infrastructure in https://github.com/apple/sourcekit-lsp/pull/859 and now log calls can specify which parts should be public and which ones should be private. All log calls should now log some public information.

[Kyle-Ye]

I redesigned the logging infrastructure in #859 and now log calls can specify which parts should be public and which ones should be private. All log calls should now log some public information.

I see it was merged into main. Is there a plan to cherry-pick it to release/5.10?

[ahoppen]

That refactoring is quite an invasive change to the entire codebase and I don’t plan to cherry-pick it to release/5.10 which doesn’t contain any of the commits that the PR relies on.