search

swiftlang / swift-book

The Swift Programming Language book
Apache License 2.0
1.76k stars 162 forks source link

fixed padding between footer social icons #322

Open shubhsaur opened 4 months ago

shubhsaur commented 4 months ago

Fix: #321

shubhsaur commented 4 months ago

Hey @krilnon, thanks for the suggestion, will look into that way as well, and for the time being have made the requested change

krilnon commented 4 months ago

@amartini51 If you have thoughts one way or the other on accepting the quick fix here or waiting for a possible upstream fix, your input is welcome.

amartini51 commented 3 months ago

Thanks for working on this fix! (I was out of the office for 2 weeks when this PR first came through. Thanks for your patience waiting for review.) I'd prefer to correct the CSS in the main Swift.org repo, and then match that correction here. I think that will also get you better review on the CSS, since there are more folks working on that repository with an expertise in CSS. I only know CSS at a general level, and have not kept up with all the latest changes.

amartini51 commented 2 months ago

Moving this PR to "draft" while the changes are being proposed and reviewed for the main Swift.org website. After we merge the changes there, we'll make the corresponding changes here.