search

swiftlang / swift-corelibs-foundation

The Foundation Project, providing core utilities, internationalization, and OS independence
swift.org
Apache License 2.0
5.29k stars 1.13k forks source link

[SR-8449] swift-corelibs-foundation: URLRequest/NSURLRequest don't hash correctly #3653

Open lorentey opened 6 years ago

lorentey commented 6 years ago
Previous ID SR-8449
Radar None
Original Reporter @lorentey
Type Bug
Status In Progress
Resolution
Additional Detail from JIRA | | | |------------------|-----------------| |Votes | 0 | |Component/s | Foundation | |Labels | Bug | |Assignee | @lorentey | |Priority | Medium | md5: 3fa3d4f99969c6d6129900fb0e168590

Issue Description:

NSURLRequest inherits hash from NSObject, but overrides isEqual: to compare contents. This also breaks hashing for URLRequest, which calls into NSURLRequest.hash.

lorentey commented 6 years ago

PR with fix is at https://github.com/apple/swift-corelibs-foundation/pull/1646