search

swiftlang / swift-corelibs-libdispatch

The libdispatch Project, (a.k.a. Grand Central Dispatch), for concurrency on multicore hardware
swift.org
Apache License 2.0
2.47k stars 461 forks source link

Switching back _dispatch_operation_perform to use posix_memalign from aligned_malloc #826

Closed PriyaAvhad closed 5 months ago

PriyaAvhad commented 7 months ago

This was caught by thread sanitizer.

PriyaAvhad commented 7 months ago

@swift-ci test

PriyaAvhad commented 7 months ago

@swift-ci please smoke test

PriyaAvhad commented 7 months ago

@swift-ci test linux

finagolfin commented 7 months ago

Sorry, only seeing this now. I will add this commit to #827 if and when you get this merged.

finagolfin commented 6 months ago

@PriyaAvhad, this pull will need to be rebased before it can be merged.

ktoso commented 6 months ago

Needs a rebase but lgtm

finagolfin commented 6 months ago

@PriyaAvhad, does #805 need to be reverted or is this one change enough?

PriyaAvhad commented 5 months ago

The thread sanitizer complaint was about just the file I have modified in this PR; but, I agree with you that it would be much cleaner to revert #805 instead.

PriyaAvhad commented 5 months ago

@swift-ci test

PriyaAvhad commented 5 months ago

@swift-ci please smoke test

PriyaAvhad commented 5 months ago

@swift-ci test linux

finagolfin commented 5 months ago

OK, if you're going to do that, then there's no need for my #827 changes for the 6.0 branch.

Just don't forget to submit this revert to the 6.0 branch next. 😉

PriyaAvhad commented 5 months ago

Will do. Thanks!