search

swiftlang / swift-corelibs-libdispatch

The libdispatch Project, (a.k.a. Grand Central Dispatch), for concurrency on multicore hardware
swift.org
Apache License 2.0
2.47k stars 460 forks source link

[6.0] Check for `aligned_alloc()` and use `posix_memalign()` instead on platforms that don't have it #827

Closed finagolfin closed 4 months ago

finagolfin commented 5 months ago

Explanation: Android before API 28 didn't have aligned_alloc(), so this simply brings back the code that was replaced in #805 for platforms like that.

Scope: Three small changes to bring back previously working code, where needed

Issue: None

Original PR: #811

Risk: None, this just brings back working code for a few platforms

Testing: Passed all CI on trunk, plus on my daily Android CI

Reviewer: @compnerd

finagolfin commented 5 months ago

Hold off on this, may need to pull in #826 too.

finagolfin commented 4 months ago

@compnerd, the author of #826 seems to have disappeared: can we go ahead and get this into 6.0, then pull in additional mods as needed later?

PriyaAvhad commented 4 months ago

Sorry I am only seeing this now. Could we use #826 to revert all the changes done here - https://github.com/apple/swift-corelibs-libdispatch/pull/805?

finagolfin commented 4 months ago

Could we use https://github.com/apple/swift-corelibs-libdispatch/pull/826 to revert all the changes done here - https://github.com/apple/swift-corelibs-libdispatch/pull/805?

Fine by me, closing this then.