swiftlang / swift-corelibs-xctest

The XCTest Project, A Swift core library for providing unit test support
swift.org
Apache License 2.0
1.15k stars 267 forks source link

Expectation handlers need to be @Sendable. #454 #455

Closed grynspan closed 1 year ago

grynspan commented 1 year ago

See for example https://developer.apple.com/documentation/xctest/xctnsnotificationexpectation/handler

The handlers for XCTestExpectation subclasses need to be @Sendable because they can be invoked asynchronously or concurrently.

Resolves #454.

grynspan commented 1 year ago

@swift-ci please test

grynspan commented 1 year ago

@swift-ci please test Windows

grynspan commented 1 year ago

@swift-ci please smoke test Windows

grynspan commented 1 year ago

Blocked by https://github.com/apple/swift-corelibs-foundation/pull/4787. Resolved.

grynspan commented 1 year ago

@swift-ci please clean test Windows