swiftlang / swift-corelibs-xctest

The XCTest Project, A Swift core library for providing unit test support
swift.org
Apache License 2.0
1.15k stars 267 forks source link

Don't use Core Foundation in tests. #471

Closed grynspan closed 10 months ago

grynspan commented 12 months ago

This PR removes a dependency on Core Foundation in a couple of our tests. The dependency is unnecessary and causes linkage issues on Windows per @etcwilde.

Resolves rdar://116586683.

compnerd commented 12 months ago

@swift-ci please test

grynspan commented 12 months ago

@swift-ci please test Windows

etcwilde commented 12 months ago

Windows failure:

[165/165][100%][2.717s] Linking C static library lib\libcurl.lib
-- Install configuration: "Release"
-- Installing: T:/Library/curl-8.4.0/usr/lib/x64/libcurl.lib
-- Installing: T:/Library/curl-8.4.0/usr/bin/x64/curl-config
-- Installing: T:/Library/curl-8.4.0/usr/lib/x64/pkgconfig/libcurl.pc
-- Installing: T:/Library/curl-8.4.0/usr/include/curl
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/curl.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/curlver.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/easy.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/header.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/mprintf.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/multi.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/options.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/stdcheaders.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/system.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/typecheck-gcc.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/urlapi.h
-- Installing: T:/Library/curl-8.4.0/usr/include/curl/websockets.h
-- Installing: T:/Library/curl-8.4.0/usr/lib/x64/cmake/CURL/CURLTargets.cmake
-- Installing: T:/Library/curl-8.4.0/usr/lib/x64/cmake/CURL/CURLTargets-release.cmake
-- Installing: T:/Library/curl-8.4.0/usr/lib/x64/cmake/CURL/CURLConfigVersion.cmake
-- Installing: T:/Library/curl-8.4.0/usr/lib/x64/cmake/CURL/CURLConfig.cmake
[0/1][  0%][0.024s] Install the project...
[2023-11-27 23:16:03] Finished building 'C:\Users\swift-ci\jenkins\workspace\swift-corelibs-xctest-PR-windows\curl' to 'T:\x64\curl-8.4.0' for arch 'x64' in 00:00:36.4609283

Copy-Item : Could not find a part of the path 
'C:\Users\swift-ci\jenkins\workspace\swift-corelibs-xctest-PR-windows\icu\icu4c\'.
At C:\Users\swift-ci\jenkins\workspace\swift-corelibs-xctest-PR-windows\swift\utils\build.ps1:990 char:7
+       Copy-Item $SourceCache\swift-installer-scripts\shared\ICU\CMake ...
+       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [Copy-Item], DirectoryNotFoundException
    + FullyQualifiedErrorId : System.IO.DirectoryNotFoundException,Microsoft.PowerShell.Commands.CopyItemCommand

@compnerd, any ideas? Looks like build.ps1 is trying to copy something that didn't get installed?

grynspan commented 12 months ago

@swift-ci please clean test Windows

grynspan commented 11 months ago

@swift-ci please test Windows

grynspan commented 11 months ago

@compnerd Do we know why this is failing? :(

compnerd commented 11 months ago

Hmm, this might be a jenkins configuration thing? CC: @shahmishal

grynspan commented 10 months ago

@swift-ci please test Windows

grynspan commented 10 months ago

Yay!