search

swiftlang / swift-corelibs-xctest

The XCTest Project, A Swift core library for providing unit test support
swift.org
Apache License 2.0
1.15k stars 267 forks source link

[Linux] Enable build IDs. #496

Closed al45tair closed 4 months ago

al45tair commented 5 months ago

We should use build IDs on Linux so that we can identify the built artefacts, and also so that we can match them up with debug information should we choose to separate it.

rdar://130582882

al45tair commented 5 months ago

@swift-ci Please test

al45tair commented 5 months ago

@swift-ci Please test

al45tair commented 5 months ago

@swift-ci Please test Windows platform

al45tair commented 5 months ago

@swift-ci Please test

al45tair commented 5 months ago

@swift-ci Please test Windows platform

al45tair commented 5 months ago

@swift-ci Please test

al45tair commented 5 months ago

@swift-ci Please test Windows platform

al45tair commented 5 months ago

@swift-ci Please test

al45tair commented 5 months ago

@swift-ci Please test Windows platform

al45tair commented 5 months ago

The macOS failure suggests that there's some configuration issue with the XCTest tests:

dyld[22635]: Symbol not found: _swift_getTypeByMangledNameInContext2
  Referenced from: <825F68B9-36A3-3A4C-842D-8F987CF7BB6E> /Users/ec2-user/jenkins/workspace/swift-corelibs-xctest-PR-macos/branch-main/swift-corelibs-xctest/Tests/Functional/TestCaseLifecycle/Misuse/Output/TestCaseLifecycleMisuse (built for macOS 14.2 which is newer than running OS)
  Expected in:     <087DADAD-D590-35EA-AC4D-7B0E966804EB> /usr/lib/swift/libswiftCore.dylib

(The "built for macOS 14.2 which is newer than running OS" part suggests that maybe the wrong deployment target is being used here.)

// @briancroom @stmontgomery

al45tair commented 5 months ago

The Windows failure seems to be a failure to fetch the sources from git.

al45tair commented 5 months ago

@swift-ci Please test Windows platform

grynspan commented 4 months ago

I don't think we generally expect corelibs-xctest to work on macOS. In the past, we've discussed removing the macOS job from CI.

al45tair commented 4 months ago

I don't think we generally expect corelibs-xctest to work on macOS. In the past, we've discussed removing the macOS job from CI.

I guess I can't merge this in that case, because the macOS platform test is marked as "Required". // @briancroom @grynspan