search

swiftlang / swift-corelibs-xctest

The XCTest Project, A Swift core library for providing unit test support
swift.org
Apache License 2.0
1.15k stars 267 forks source link

Guard parse_version #498

Closed etcwilde closed 2 months ago

etcwilde commented 5 months ago

main cherry-pick of https://github.com/apple/swift-corelibs-xctest/pull/489.

The most recent versions of parse_version throw an exception if the version is empty. The version passed in is only set on Darwin (call to mac_ver(), so it's causing test failures on newer versions of Linux since the test suite can't even start.

Now, the only reason for the version parse is because the tests are looking at whether or not concurrency is available on the OS. This is only a limitation if we're working with Darwin. Swift 5.10 on Windows and Linux always have a Swift 5.10 concurrency runtime, so we don't even need to check for a version.

rdar://128502662 (cherry picked from commit 65e6ecdce29101129911c49760b0f85ac18d21e5)

etcwilde commented 5 months ago

@swift-ci please test

etcwilde commented 3 months ago

@swift-ci please test

etcwilde commented 3 months ago

@swift-ci please test Linux

etcwilde commented 3 months ago

https://github.com/apple/swift-foundation/pull/885 @swift-ci please test Linux

grynspan commented 2 months ago

@swift-ci test

grynspan commented 2 months ago

@etcwilde Do you still want to merge this change?

etcwilde commented 2 months ago

Yeah, we'll need it eventually when working with newer python versions. I'm starting to think maybe my change did break something, but I haven't had a chance to figure out why.

shahmishal commented 2 months ago

@swift-ci test

etcwilde commented 2 months ago

https://github.com/swiftlang/sourcekit-lsp/pull/1666

@swift-ci please test

etcwilde commented 2 months ago

@swift-ci please test

etcwilde commented 2 months ago

@swift-ci please test Windows platform