swiftlang / swift-docc-render

Web renderer for Swift-DocC documentation.
Apache License 2.0
311 stars 50 forks source link

External docc links stopped working in Xcode Version 16.0 beta 5 (16A5221g) #885

Closed jverkoey closed 1 month ago

jverkoey commented 1 month ago

Description

A link like this:

SwiftUI's [HStack](https://developer.apple.com/documentation/swiftui/hstack)

used to work in Xcode Version 16.0 beta 4, as seen in https://jverkoey.github.io/slipstream/documentation/slipstream/slipstreamforswiftuidevelopers:

Screenshot 2024-08-07 at 3 06 45 PM

But as of Xcode Version 16.0 beta 5 (16A5221g), these same links no longer generate linked text:

Screenshot 2024-08-07 at 3 07 36 PM

Checklist

Expected Behavior

The link turns into an a element in the generated html.

Actual behavior

External links are not translated to a elements.

Steps To Reproduce

Include an external link like so:

SwiftUI's [HStack](https://developer.apple.com/documentation/swiftui/hstack)

Swift-DocC Version Information

26ac5758409154cc448d7ab82389c520fa8a8247

Swift Compiler Version Information

swift-driver version: 1.113 Apple Swift version 6.0 (swiftlang-6.0.0.7.6 clang-1600.0.24.1)
Target: arm64-apple-macosx14.0
d-ronnqvist commented 1 month ago

The issue is that Swift-DocC-Render seems to skip https links.

d-ronnqvist commented 1 month ago

AFAICT this is caused by https://github.com/swiftlang/swift-docc-render/pull/878

jverkoey commented 1 month ago

Is there a recommended way to reenable external links with that in mind?

jverkoey commented 1 month ago

Thank you!

On Thu, Aug 8, 2024 at 12:34 PM Marcus Ortiz @.***> wrote:

I think I broke this with #878 https://github.com/swiftlang/swift-docc-render/pull/878 as @d-ronnqvist https://github.com/d-ronnqvist pointed out. I'll prioritize fixing this asap.

— Reply to this email directly, view it on GitHub https://github.com/swiftlang/swift-docc-render/issues/885#issuecomment-2276230723, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAALEZWGZROPVYJ6UA3EBWDZQOMX5AVCNFSM6AAAAABMF64GAKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENZWGIZTANZSGM . You are receiving this because you authored the thread.Message ID: @.***>