Fix git usability for CentOS 7 nightly images

swiftlang / swift-docker

Docker Official Image packaging for Swift

https://swift.org

Apache License 2.0

1.36k stars 182 forks source link

Fix git usability for CentOS 7 nightly images #306

Closed stevapple closed 2 years ago

stevapple commented 2 years ago

Git 2.x introduced in #274 is not enabled correctly, because its networking feature depends on httpd24 from RH software collections, which is not in the library search path.

This PR attempts to enable the Git installation correctly by using the official enable script. This also enhances compatibility and robustness against any possible dependency changes.

stevapple commented 2 years ago

cc @shahmishal @tomerd

stevapple commented 2 years ago

ping again @shahmishal @tomerd

shahmishal commented 2 years ago

@swift-ci test

shahmishal commented 2 years ago

Do we need to pull this into 5.7/nightly-5.7 Dockerfiles too?

stevapple commented 2 years ago

@shahmishal Git 2.x is not enabled on 5.7 images yet, so is this patch.