Install a Swift 5.8.1 toolchain in all swift-ci images

[bnbarham]

Installs a Swift 5.8.1 toolchain into /opt/swift/<version> on each Linux platform. Removes clang since the toolchain clang can be used instead.

[bnbarham]

@shahmishal has some docker-compose ideas here IIUC.

With the base docker... not really. You could share a common base image, but this is the other way around - ie. we have a bunch of images that we then want to add a toolchain on top of. Could do some generator-like hackery I suppose, but I'm not sure that's really better (eg. could just have a makefile that concats a bunch of files together 😅). Another alternative would be something like edrevo/dockerfile-plus.

[shahmishal]

@swift-ci test

[tomerd]

There's no way to share this code across Dockerfiles?

some of this can be made into a script that is that can be copied & used in the docker file

[bnbarham]

There's no way to share this code across Dockerfiles?

some of this can be made into a script that is that can be copied & used in the docker file

Ah that's a good point. Could do that, the extra curl for Ubuntu is a little annoying but we could install based on a parameter for that script.

[tomerd]

the extra curl for Ubuntu is a little annoying but we could install based on a parameter for that script.

a bit less efficient from docker caching pov but we can install curl on ubuntu before the ADD and RUN commands for the script, then remove after. or even a more lazy approach, we can just include curl on these images in the main dependencies list even if we dont really need it for anything else

[MaxDesiatov]

@swift-ci test

[bnbarham]

@swift-ci test

[bnbarham]

@swift-ci please test

[bnbarham]

@swift-ci please test