Windows: update the 5.9 image rules

swiftlang / swift-docker

Docker Official Image packaging for Swift

https://swift.org

Apache License 2.0

1.35k stars 182 forks source link

Windows: update the 5.9 image rules #357

Closed compnerd closed 10 months ago

compnerd commented 10 months ago

Update the Dockerfile to address feedback from the docker library maintainers. Install the python package before VS. Add installer validation, which is easier as a series of powershell scripts. This should be a bit more flexible for us now.

shahmishal commented 10 months ago

@swift-ci test

shahmishal commented 10 months ago

If possible, it does not need to be in this PR.

Can we update the ci_test to check windows dockerfiles?

https://github.com/apple/swift-docker/blob/main/ci_test.py#L47C9-L49C41

compnerd commented 10 months ago

@swift-ci please test

compnerd commented 10 months ago

@swift-ci please test

compnerd commented 10 months ago

@shahmishal - I think that I got what you were suggesting in the change?

compnerd commented 10 months ago

@swift-ci please test

compnerd commented 10 months ago

@swift-ci please test

shahmishal commented 10 months ago

@swift-ci test