search

swiftlang / swift-docker

Docker Official Image packaging for Swift
https://swift.org
Apache License 2.0
1.35k stars 182 forks source link

Correct the padding on the /etc/motd banners #379

Closed jonEbird closed 4 months ago

jonEbird commented 4 months ago

The prior tab based padding of the /etc/motd banner lended itself to an error in the padding in length depending on the value of the Swift tag contents. The approach of using printf is a bit more friendly from a maintenance perspective.

Lastly, there was a bug in how the bash code was included where the value of $TERM wasn't be escaped properly so you'd get a hardcoded value vs. the variable $TERM.

shahmishal commented 4 months ago

@swift-ci test

shahmishal commented 4 months ago

@jonEbird Can we limit this change to active nightly Dockerfiles?

jonEbird commented 4 months ago

@jonEbird Can we limit this change to active nightly Dockerfiles?

  • main
  • 6.0
  • 5.10

Sure thing. I've updated the commit to only include those.

shahmishal commented 4 months ago

@swift-ci test