The legacy logic for extracting review period dates makes outdated assumptions, including logic that works around the lack of a year in the source proposal date. The year is now always included.
The legacy logic was used in the new tool largely as-is to ensure results were equal between the old and new implementation to enable testing that the new tool generated the same results.
After the new tool is in production, the legacy logic in StatusExtractor.swift in datesForString() should be revisited and revised.
Note the source files for the testGoodDates() and testGoodDates() tests would likely need updating as well.
The legacy logic for extracting review period dates makes outdated assumptions, including logic that works around the lack of a year in the source proposal date. The year is now always included.
The legacy logic was used in the new tool largely as-is to ensure results were equal between the old and new implementation to enable testing that the new tool generated the same results.
After the new tool is in production, the legacy logic in
StatusExtractor.swiftindatesForString()should be revisited and revised.Note the source files for the
testGoodDates()andtestGoodDates()tests would likely need updating as well.