search

swiftlang / swift-experimental-string-processing

An early experimental general-purpose pattern matching engine for Swift.
Apache License 2.0
278 stars 47 forks source link

Overhaul quantification optimizations #716

Closed Catfish-Man closed 8 months ago

Catfish-Man commented 8 months ago

Finishing up @milseman's https://github.com/apple/swift-experimental-string-processing/pull/710

Catfish-Man commented 8 months ago

@swift-ci please test

Catfish-Man commented 8 months ago

New assertion already paying off

Test Case 'AlgorithmTests.testMatchesCollection' started at 2024-02-03 00:43:54.316 _StringProcessing/MEQuantify.swift:133: Assertion failed

Catfish-Man commented 8 months ago

@swift-ci please test

Catfish-Man commented 8 months ago

Nate thinks the remaining test failure is due to CI trying to run the tests concurrently

Catfish-Man commented 8 months ago

Failure appears to be pre-existing, going ahead and merging

milseman commented 8 months ago

@Catfish-Man Err, this is hitting an assert introduced by this PR. Should we revert and fix?

edit: I see, that was pre-fix. Let's in general try to get a clean CI before merging though, unless there's an emergency rush.

milseman commented 8 months ago

Is it a problem for tests to run concurrently? Why?

Catfish-Man commented 8 months ago

Ok. I discussed with Nate first and made sure it passed locally