Closed Catfish-Man closed 8 months ago
@swift-ci please test
New assertion already paying off
Test Case 'AlgorithmTests.testMatchesCollection' started at 2024-02-03 00:43:54.316 _StringProcessing/MEQuantify.swift:133: Assertion failed
@swift-ci please test
Nate thinks the remaining test failure is due to CI trying to run the tests concurrently
Failure appears to be pre-existing, going ahead and merging
@Catfish-Man Err, this is hitting an assert introduced by this PR. Should we revert and fix?
edit: I see, that was pre-fix. Let's in general try to get a clean CI before merging though, unless there's an emergency rush.
Is it a problem for tests to run concurrently? Why?
Ok. I discussed with Nate first and made sure it passed locally
Finishing up @milseman's https://github.com/apple/swift-experimental-string-processing/pull/710