Explanation: Deleting path components from a URL on Windows will never end up with a path / because Windows has drive letters. On Linux, we end up with an empty path instead of / because of https://github.com/swiftlang/swift-foundation/issues/980.
Scope: Directory traversal in the search for a .swift-format file
Risk: Low, the existing logic is still in place, we just increase the number of directories that we consider root and all of those checks should be safe
Testing: Add test cases, manually verified that we terminate the directory traversal on Linux and Windows
ahoppen
commented
1 month ago
/because Windows has drive letters. On Linux, we end up with an empty path instead of/because of https://github.com/swiftlang/swift-foundation/issues/980..swift-formatfile