Closed jrflat closed 1 month ago
Original 6.0 cherry-pick: #903 Description from that cherry-pick:
Explanation: Percent-encode the host (instead of IDNA-encoding) for URLs with the http+unix or https+unix scheme, supporting the common representation of a "HTTP over Unix socket" URL. This fixes http(s)+unix-related regressions in clients such as Vapor and AsyncHTTPClient (see https://github.com/apple/swift-foundation/issues/863 and https://github.com/swift-server/async-http-client/issues/767) Scope: Only impacts http+unix and https+unix URLs, adds them to the set of schemesToPercentEncodeHost Original PR: https://github.com/apple/swift-foundation/pull/883 Risk: Low - narrow scope, added special casing of two schemes to a larger set that has been well tested Testing: Local, swift-ci, stable in main for 2 weeks, verified to fix https://github.com/swift-server/async-http-client/issues/767 Reviewer: @parkera
http+unix
https+unix
http(s)+unix
schemesToPercentEncodeHost
main
@swift-ci please test
jrflat
commented
1 month ago jrflat
commented
1 month ago
Original 6.0 cherry-pick: #903 Description from that cherry-pick:
Explanation: Percent-encode the host (instead of IDNA-encoding) for URLs with the
http+unixorhttps+unixscheme, supporting the common representation of a "HTTP over Unix socket" URL. This fixeshttp(s)+unix-related regressions in clients such as Vapor and AsyncHTTPClient (see https://github.com/apple/swift-foundation/issues/863 and https://github.com/swift-server/async-http-client/issues/767) Scope: Only impactshttp+unixandhttps+unixURLs, adds them to the set ofschemesToPercentEncodeHostOriginal PR: https://github.com/apple/swift-foundation/pull/883 Risk: Low - narrow scope, added special casing of two schemes to a larger set that has been well tested Testing: Local, swift-ci, stable inmainfor 2 weeks, verified to fix https://github.com/swift-server/async-http-client/issues/767 Reviewer: @parkera