search

swiftlang / swift-foundation

The Foundation project
Apache License 2.0
2.4k stars 160 forks source link

[6.0][Android] Enable more code and tests (#871) #923

Closed finagolfin closed 1 month ago

finagolfin commented 1 month ago

Explanation: This gets the remaining tests passing natively on Android while disabling setting extended file attributes and modifying a test that creates a hard link, features not normally allowed on Android. I also removed an incorrect WASI check I found.

Scope: Only affects Android, no other platforms' code is touched.

Issue: None

Original PRs: #871

Risk: None

Testing: Passed all CI on trunk and my testing locally.

Reviewer: @jmschonfeld

This is useful for me and others who distribute Android SDKs or a toolchain, and won't break anything for other platforms.

finagolfin commented 1 month ago

@jmschonfeld, need a CI run here, I just added this to my Android CI to build 6.0.

jmschonfeld commented 1 month ago

@swift-ci please test

finagolfin commented 1 month ago

Passed CI, @parkera, ready for review.

parkera commented 1 month ago

We'll have to double check which 6.0 release this eventually gets into. I think it'll be post-6.0.2 now unless there is one more cherry pick.

finagolfin commented 1 month ago

6.0.3 is fine, as long as I can retire it from my downstream patches eventually.